Re: Fixing memory leak in pg_upgrade

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: michael(dot)paquier(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fixing memory leak in pg_upgrade
Date: 2015-01-10 02:19:44
Message-ID: 20150110.111944.563424590546355319.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Fri, Jan 9, 2015 at 9:23 PM, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>> This is because gen_db_file_maps() allocates memory even if n_maps == 0.
> Purely cosmetic: the initialization n_maps = 0 before the call of
> gen_db_file_maps is unnecessary ;)

Of course. n_maps is written by calling gen_db_file_maps() anyway. I
was talking about the case after calling gen_db_file_maps().

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-01-10 02:25:42 Re: Escaping from blocked send() reprised.
Previous Message Andres Freund 2015-01-10 01:59:07 Re: Escaping from blocked send() reprised.