| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: add modulo (%) operator to pgbench |
| Date: | 2015-01-05 14:42:09 |
| Message-ID: | 20150105144209.GK1457@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley wrote:
> I'm also just looking at you ERROR() macro, it seems that core code is
> quite careful not to use __VA_ARGS__ on compilers where HAVE__VA_ARGS is
> not defined. I'd say this needs to be fixed too. Have a look at the trick
> used in elog.h for when HAVE__VA_ARGS is not defined.
Hm, I just looked at the previous version which used ERROR rather than
LOCATE and LOCATION, and I liked that approach better. Can we get that
back? I understand that for the purposes of this patch it's easier to
not change existing fprintf()/exit() calls, though.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-01-05 15:01:07 | Re: Parallel Seq Scan |
| Previous Message | Alvaro Herrera | 2015-01-05 14:38:39 | Re: add modulo (%) operator to pgbench |