Re: pg_basebackup -x/X doesn't play well with archive_mode & wal_keep_segments

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup -x/X doesn't play well with archive_mode & wal_keep_segments
Date: 2015-01-05 12:34:13
Message-ID: 20150105123413.GC3370@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-01-05 18:49:06 +0900, Fujii Masao wrote:
> On Mon, Jan 5, 2015 at 6:22 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> > On 2015-01-05 16:22:56 +0900, Fujii Masao wrote:
> >> On Sun, Jan 4, 2015 at 5:47 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> >> > On 2015-01-03 16:03:36 +0100, Andres Freund wrote:
> >> > pg_basebackup really
> >> > changed heavily since it's introduction. And desparately needs some
> >> > restructuring.
> >>
> >> The patch seems to break pg_receivexlog. I got the following error message
> >> while running pg_receivexlog.
> >
> >> pg_receivexlog: could not create archive status file
> >> "mmm/archive_status/000000010000000000000003.done": No such file or
> >> directory
> >
> > Dang. Stupid typo. And my tests didn't catch it, because I had
> > archive_directory in the target directory :(
> >
> > At least it's only broken in master :/

I've pushed the trivial fix, and verified using my adapted testscript
that it works on all branches.

> > Thanks for the catch. Do you have some additional testsuite or did you
> > catch it manually?
>
> Manually... I just tested the tools and options which the patch may affect...

Thanks!

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2015-01-05 13:29:56 Re: [REVIEW] Re: Compression of full-page-writes
Previous Message Michael Paquier 2015-01-05 11:36:40 Re: [RFC] Incremental backup v3: incremental PoC