| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Move pg_lzcompress.c to src/common. |
| Date: | 2014-12-25 16:05:11 |
| Message-ID: | 20141225160511.GG31801@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2014-12-25 23:46:52 +0900, Michael Paquier wrote:
> On Thu, Dec 25, 2014 at 10:43 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> > /*
> > * We have to use postgres.h not postgres_fe.h here, because there's so much
> > * backend-only stuff in the XLOG include files we need. But we need a
> > * frontend-ish environment otherwise. Hence this ugly hack.
> > */
> > #define FRONTEND 1
> >
> > #include "postgres.h"
> Urgh.. Would that mean keeping a local copy of SET_VARSIZE_4B_C and
> VARSIZE_4B if this hack is not used? Looking at the git history, I am
> seeing similar things in 2008 where pg_crc stuff was moved to src/port
> (5c9c08d).
Surely not. It seems like a much better idea to not have lzcompress deal
with varlena at all but pass that responsibility one layer upwards. That
shouldn't be very hard.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-12-25 16:49:00 | pgsql: Convert the PGPROC->lwWaitLink list into a dlist instead of open |
| Previous Message | Michael Paquier | 2014-12-25 14:46:52 | Re: pgsql: Move pg_lzcompress.c to src/common. |