Re: Missing updates at few places for row level security

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing updates at few places for row level security
Date: 2014-12-23 12:11:32
Message-ID: 20141223121132.GA3062@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Amit,

* Amit Kapila (amit(dot)kapila16(at)gmail(dot)com) wrote:
> There is a new column added in pg_authid (rolbypassrls)
> and the updation for same is missed in below places:
>
> a. System catalog page for pg_authid
> http://www.postgresql.org/docs/devel/static/catalog-pg-authid.html

Yup, thanks, will fix.

> b. Do we want to add this new column in pg_shadow view?

This was intentionally not done as I had really viewed pg_user, pg_group
and pg_shadow as deprecated and only for backwards-compatibility.
That's certainly why those views were added originally. On the other
hand, I do see that 'userepl' was added, so we've been keeping it
updated.

I am inclined to suggest that we actually mark pg_user, pg_group, and
pg_shadow as deprecated and planned for removal. We can't simply remove
them as we haven't actually said that but I don't think we should
continue to carry these pre-8.1 views around forever. Still, until we
do that, we should keep them updated.

I'll make these changes in the next couple of days (after the role
attribute bitmask patch, as that touches a lot of the same places).

Thanks,

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2014-12-23 12:14:08 Re: Initdb-cs_CZ.WIN-1250 buildfarm failures
Previous Message Teodor Sigaev 2014-12-23 11:24:43 Re: speedup tidbitmap patch: cache page