Re: pgsql: doc: restrictions on alter database moving default tablespace

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: doc: restrictions on alter database moving default tablespace
Date: 2014-12-20 02:03:22
Message-ID: 20141220020322.GB21109@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Dec 19, 2014 at 02:09:10AM -0500, Noah Misch wrote:
> On Mon, Dec 15, 2014 at 09:27:38PM -0700, David G Johnston wrote:
> > Noah Misch-2 wrote
> > > Here are a couple of alternatives for the documentation text:
> > >
> > > The new default tablespace must not already contain any of the
> > > database's
> > > objects, and no one can be connected to the database.
> >
> > +1; though maybe...
> >
> > The newly assigned default tablespace must not contain any of the specified
> > database's objects but otherwise need not be empty. Additionally, there
> > must not be anyone connected to the database.
> >
> > This is a bit more verbose, and somewhat implied since newly created
> > databases have their default set, by definition, to one hat likely already
> > contains objects of other databases in the cluster, but does clarify the
> > specific confusion raised here. Re-reading I think the implicit version is
> > likely sufficiently clear though.
>
> That text, too, works for me.

I went with cleaner wording that just rearranges the text to avoid the
confusion. Attached patch applied.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
alter.diff text/x-diff 1.0 KB

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2014-12-20 06:19:58 Re: pgsql: Allow pushdown of WHERE quals into subqueries with window functi
Previous Message Bruce Momjian 2014-12-20 01:56:07 pgsql: doc: Adjust wording of ALTER TABLESPACE restriction