| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: moving from contrib to bin |
| Date: | 2014-12-12 16:45:12 |
| Message-ID: | 20141212164512.GB25589@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-12-12 11:42:57 -0500, Robert Haas wrote:
> > I think the amount of effort a simple renamed directory which wholly
> > contains a binary creates is acceptable. Just use patch -p4 instead of
> > patch -p1...
>
> That is fine if you are manually applying a patch that touches only
> that directory, but if the patch also touches other stuff then it's
> not as simple.
I think backpatchable commits that touch individual binaries and other
code at the same time are (and ought to be!) pretty rare.
> And I don't know how well git cherry-pick will follow
> the moves.
Not well if the patch is done in master first.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2014-12-12 16:50:56 | Re: PATCH: hashjoin - gracefully increasing NTUP_PER_BUCKET instead of batching |
| Previous Message | Robert Haas | 2014-12-12 16:42:57 | Re: moving from contrib to bin |