| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: New wal format distorts pg_xlogdump --stats |
| Date: | 2014-12-04 23:09:54 |
| Message-ID: | 20141204230954.GD21964@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-12-04 16:26:02 +0200, Heikki Linnakangas wrote:
> Yeah, that's broken.
>
> I propose the attached. Or does anyone want to argue for adding an
> XLogRecGetFPILen() accessor macro for the hole_length in xlogreader.h. It's
> not something a redo routine would need, nor most XLOG-reading applications,
> so I thought it's better to just have pg_xlogdump peek into the
> DecodedBkpBlock struct directly.
I think both would be justifyable, so I don't really care for now. One
slight reason for wrapping it in xlogreader.h is that we might add
compression of some form or another soon and it'd possibly be better to
have it in xlogreader.h so pg_xlogdump doesn't have to be changed. But
that's really rather minor.
Thanks,
Andres
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matt Newell | 2014-12-04 23:49:52 | Re: libpq pipelining |
| Previous Message | Peter Geoghegan | 2014-12-04 22:59:56 | Re: Minor documentation tweak to pg_stat_all_tables view description |