| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Move security_label test |
| Date: | 2014-12-02 20:46:01 |
| Message-ID: | 20141202204601.GR1737@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Peter Eisentraut wrote:
> On 12/2/14 9:18 AM, Alvaro Herrera wrote:
> >> After this module has been moved to src/test/modules, I am seeing
> >> > failures with make check when manually kicking the test on at least
> >> > OSX where I tried because expected/ and sql/ are missing. pg_regress
> >> > does not like that much. That's annoying because check-world would
> >> > simply fail.
> > I had the directories locally but hadn't git-pushed them.
>
> make check-world still fails.
Ah, it needs errcodes.h to be generated. We can add this (or similar)
to the makefiles:
OBJS: | submake-errcodes
submake-errcodes:
$(MAKE) -C $(top_builddir)/src/backend submake-errcodes
but it would be very repetitive to have it in all test modules'
makefiles. Why doesn't contrib need this? Do you have a better idea?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-12-02 23:04:19 | pgsql: Don't skip SQL backends in logical decoding for visibility compu |
| Previous Message | Tom Lane | 2014-12-02 20:02:55 | pgsql: Fix JSON aggregates to work properly when final function is re-e |