Re: superuser() shortcuts

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: superuser() shortcuts
Date: 2014-11-26 13:33:10
Message-ID: 20141126133309.GV28859@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> On Sun, Nov 23, 2014 at 3:38 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> >> I'm not really particular about which way we go with the specific
> >> wording (suggestions welcome..) but the inconsistency should be dealt
> >> with.
> >
> > Meh.
>
> +1 for "meh". I don't mind making things consistent if it can be done
> while maintaining or improving the absolute quality of those error
> messages -- but if the changes involve a loss of detail, or moving
> information that used to be in the main error message into the detail,
> then I don't think it's worth it.

Doesn't that argument then apply to the other messages which I pointed
out in my follow-up to Andres, where the detailed info is in the hint
and the main error message is essentially 'permission denied'? Also, if
we're going to make these error-messages related to role attributes be
'you need role attribute X', should we consider doing the same for the
regular 'permission denied' error messages?

I can understand the arguments about loss of detail or having the detail
in the hint instead of the error message. I don't understand why we'd
want the messaging to be inconsistent.

Thanks,

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2014-11-26 13:35:36 Re: BUG #12071: Stat collector went crasy (50MB/s constant writes)
Previous Message Maxim Boguk 2014-11-26 13:25:33 Re: BUG #12071: Stat collector went crasy (50MB/s constant writes)