| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Rahila Syed <rahilasyed(dot)90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
| Date: | 2014-11-25 13:48:48 |
| Message-ID: | 20141125134848.GD1639@alvin.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier wrote:
> Exposing compression and decompression APIs of pglz makes possible its
> use by extensions and contrib modules. pglz_decompress contained a call
> to elog to emit an error message in case of corrupted data. This function
> is changed to return a boolean status to let its callers return an error
> instead.
I think pglz_compress belongs into src/common instead. It
seems way too high-level for src/port.
Isn't a simple boolean return value too simple-minded? Maybe an enum
would be more future-proof, as later you might want to add more values,
say distinguish between different forms of corruption, or fail due to
out of memory, whatever.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2014-11-25 14:06:12 | Re: Add shutdown_at_recovery_target option to recovery.conf |
| Previous Message | Alex Shulgin | 2014-11-25 13:47:58 | Re: Missing OOM checks in libpq (was Re: Replication connection URI?) |