|From:||Andres Freund <andres(at)2ndquadrant(dot)com>|
|To:||Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>|
|Cc:||Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org|
|Subject:||Re: initdb -S and tablespaces|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2014-10-30 14:30:28 +0530, Abhijit Menon-Sen wrote:
> Here's a proposed patch to initdb to make initdb -S fsync everything
> under pg_tblspc. It introduces a new function that calls walkdir on
> every entry under pg_tblspc. This is only one approach: I could have
> also changed walkdir to follow links, but that would have required a
> bunch of #ifdefs for Windows (because it doesn't have symlinks), and I
> guessed a separate function with two calls might be easier to patch into
> back branches. I've tested this patch under various conditions on Linux,
> but it could use some testing on Windows.
I've pushed this. The windows buildfarm animals that run pg_upgrade (and
thus --sync-only) will have to tell us whether there's a problem. I sure
hope there's none...
Thanks for that patch!
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
|Next Message||Andres Freund||2014-11-15 00:38:57||Re: END_OF_RECOVERY shutdowns and ResetUnloggedRelations()|
|Previous Message||Stephen Frost||2014-11-14 23:01:42||Re: On the warpath again about ill-considered inclusion nests|