| From: | Andres Freund <andres(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing FIN_CRC32 calls in logical replication code |
| Date: | 2014-11-11 16:55:41 |
| Message-ID: | 20141111165541.GJ18565@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-11-03 21:58:51 +0200, Heikki Linnakangas wrote:
> PS. I find the name "ReplicationSlotOnDiskDynamicSize" confusing, as it is
> in fact a fixed size struct. I gather it's expected that the size of that
> part might change across versions, but by that definition nothing is
> constant.
Well, the idea is that the 'constant' part is version independent. The
part following afterwards (dynamic) can differ based on the 'version'
struct member. The reason is that that allows files from older releases
to be read after a pg_upgrade.
If you have suggestions for better names.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2014-11-11 17:09:54 | Re: tracking commit timestamps |
| Previous Message | Simon Riggs | 2014-11-11 16:20:25 | Re: tracking commit timestamps |