| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Defining dedicated macro to grab a relation's persistence |
| Date: | 2014-11-07 13:12:49 |
| Message-ID: | 20141107131249.GA4510@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2014-11-07 22:08:33 +0900, Michael Paquier wrote:
> After looking at a patch of this commit fest using
> rd_rel->relpersistence, I got a look at how many times this expression
> was being used directly in the backend code and wondered if it would
> not be useful to add a dedicated macro in rel.h to get the persistence
> of a relation like in the patch attached. (Note: it is actually used
> 39 times).
I personally find the direct access actually more readable, so I'm not a
fan of further extending the scheme. Consistency with some other common
accessors is an argument though.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-11-07 13:24:45 | Re: [HACKERS] ltree::text not immutable? |
| Previous Message | Michael Paquier | 2014-11-07 13:08:33 | Defining dedicated macro to grab a relation's persistence |