| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: infinite loop in _bt_getstackbuf |
| Date: | 2014-11-01 00:30:38 |
| Message-ID: | 20141101003038.GA433704@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 31, 2014 at 10:29:53AM -0400, Robert Haas wrote:
> On Thu, Oct 30, 2014 at 11:45 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> >> Given the lack of prior complaints about this
> >> loop, I'm not sure I see the need to work harder than that; corruption
> >> of this sort must be quite rare.
> >
> > Looks like _bt_getstackbuf() is always called with some buffer lock held, so
> > CHECK_FOR_INTERRUPTS() alone would not help:
> >
> > http://www.postgresql.org/message-id/flat/16519(dot)1401395152(at)sss(dot)pgh(dot)pa(dot)us
>
> That's the insert path. What about the vacuum path?
I am not aware of an occasion where the vacuum path will call
_bt_getstackbuf() without already holding some buffer lock.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-11-01 01:25:02 | Re: group locking: incomplete patch, just for discussion |
| Previous Message | Jim Nasby | 2014-10-31 23:12:57 | Re: pg_background (and more parallelism infrastructure patches) |