Re: TAP test breakage on MacOS X

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TAP test breakage on MacOS X
Date: 2014-10-31 00:07:21
Message-ID: 20141031000721.GO17724@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-10-30 19:53:54 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On 2014-10-30 19:30:04 -0400, Tom Lane wrote:
> >> At some point down the road that value judgement might (hopefully will)
> >> reverse, and then we could deal with it by making --enable-tap-tests the
> >> default. But even then there would be a place for
> >> --disable-tap-tests.
>
> > Which would be what exactly?
>
> Well, for example, you don't have and don't want to install IPC::Run.

Well, that's what the hypothetical configure test is for. I see little
reason in this specific case to do anything more complicated than check
for prove and IPC::Run in configure and use them if necessary.

> Or you've tripped over some failure in the TAP tests (which might or
> might not be an actual bug) but would like to complete your build anyway.

Well. That's just the same with plain regression tests. But I guess
adding --disable is essentially free, so whatever.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2014-10-31 00:11:35 Re: how to handle missing "prove"
Previous Message Tomas Vondra 2014-10-30 23:59:32 Re: SET TABLESPACE ... NOWAIT