| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "maxim(dot)boguk" <maxim(dot)boguk(at)gmail(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #10675: alter database set tablespace and unlogged table |
| Date: | 2014-10-20 22:01:50 |
| Message-ID: | 20141020220150.GI7176@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2014-10-10 16:15:58 +0900, Fujii Masao wrote:
> +1 for applying this change.
I've just done so.
> - (flags & CHECKPOINT_CAUSE_TIME) ? " time" : "");
> + (flags & CHECKPOINT_CAUSE_TIME) ? " time" : "",
> + (flags & CHECKPOINT_FLUSH_ALL) ? " flush-all" :"");
>
> ISTM that you forgot to add the following change.
>
> - msg = "restartpoint starting:%s%s%s%s%s%s%s";
> + msg = "restartpoint starting:%s%s%s%s%s%s%s%s";
> else
> - msg = "checkpoint starting:%s%s%s%s%s%s%s";
> + msg = "checkpoint starting:%s%s%s%s%s%s%s%s";
Good catch. Thanks for having a look! Interesting that gcc can't deduce
this...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | forgottenandlost | 2014-10-21 04:54:02 | BUG #11731: installer reliance on default file association for vbs scripts |
| Previous Message | Kevin Grittner | 2014-10-20 20:44:22 | Re: BUG #11705: \d(escribe) table shows incorrect check constraint |