Re: proposal: rounding up time value less than its unit.

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tomonari Katsumata <t(dot)katsumata1122(at)gmail(dot)com>
Cc: David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: rounding up time value less than its unit.
Date: 2014-09-23 03:19:51
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


* Tomonari Katsumata (t(dot)katsumata1122(at)gmail(dot)com) wrote:
> I'm thinking about a method which users get quick awareness it.
> Now, it's okay not to change current behavior except non-zero value yields
> a zero. A zero rounded down from non-zero gets an error.
> I attached new patch.
> This includes a document about above behavior as Heikki suggested.

Thanks for the updated patch! I was going through it and there's a few

- Documentation change no longer applies

- Why aren't we worried about a specification of '7kB' being rounded down
to zero for GUCs which expect at least BLCKSZ? If the reason is
"everything that works that way will error on zero anyway today", then
I don't buy into that argument- there's no sense leaving it
inconsistent and it would be a potential land-mine to hit later.

- The hint messages look like they need some rewording, at least.

In general, I'm a fan of this change and will move forward with it,
with changes for the above, unless folks object. Based on the thread so
far, this sounds like the right solution and it'd be great to get this
simple change done to help move the CF along.



In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2014-09-23 03:23:43 Re: RLS feature has been committed
Previous Message Craig Ringer 2014-09-23 02:23:02 Re: Anonymous code block with parameters