Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop]

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, MauMau <maumau307(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>
Subject: Re: [Fwd: Re: proposal: new long psql parameter --on-error-stop]
Date: 2014-09-09 20:22:45
Message-ID: 20140909202245.GB24649@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Given we already have three topics for --help and I can see others I
went with my --help= proposal.

On 2014-08-28 13:20:07 +0200, Andres Freund wrote:
> Some stuff I changed:
> * I rephrased the sgml changes
> * s/Printing options/Display options/. Or maybe "Display influencing
> variables"? That makes it clearer why they're listed under
> --help-variables.
> * I added \? commands as an alias for a plain \?
> That way the scheme can sensibly be expanded.
> * I renamed help_variables() to be inline with the surrounding functions.

I integrated all those ontop of your help-variables-12.patch.

Then I:
* re-added psql -i which you, probably accidentally, removed
* rephrased the sgml stuff
* removed the "Report bugs to " from helpVariables()
* Changed things so that both --help and \? support "commands",
"options" and "variables" as help topics
* fixed things so that --help=wrongoption returns a proper exit code
again

I attached both the full and the incremental diff. I'd appreciate
somebody looking over the the docs...

I plan to push this soon.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
help-variables-13.patch text/x-patch 23.2 KB
help-variables-12--13.diff text/x-diff 9.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-09-09 20:48:45 Re: pg_background (and more parallelism infrastructure patches)
Previous Message David Johnston 2014-09-09 19:40:45 Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?