Re: Re: [BUGS] Re: BUG #9555: pg_dump for tables with inheritance recreates the table with the wrong order of columns

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [BUGS] Re: BUG #9555: pg_dump for tables with inheritance recreates the table with the wrong order of columns
Date: 2014-09-03 16:07:55
Message-ID: 20140903160755.GG14893@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Mon, Sep 1, 2014 at 04:40:11PM -0400, Bruce Momjian wrote:
> On Mon, Sep 1, 2014 at 04:06:58PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > NOTICE: moving and merging column "c" with inherited definition
> > > DETAIL: user-specified column moved to the location of the inherited
> > > column
> >
> > Dept of nitpicking: errdetail messages are supposed to be complete
> > sentences, properly capitalized and punctuated. Please re-read the
> > style guidelines if you have forgotten them.
>
> Oh, yeah; updated patch attached.

OK, patch applied. This will warn about reordering that happens via
SQL, and via pg_dump restore. Do we want to go farther and preserve
column ordering by adding ALTER TABLE [constraint] ISLOCAL and have
pg_dump reuse binary-upgrade mode?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Zeb Haradon 2014-09-03 17:43:07 postgres randomly gets into state where it returns hstore as string
Previous Message Matheus de Oliveira 2014-09-03 12:50:09 Re: BUG #11344: ALTER TABLE ... SET SCHEMA ... do not recurse to inherited tables

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-09-03 16:51:38 Re: INSERT ... ON CONFLICT {UPDATE | IGNORE}
Previous Message Andres Freund 2014-09-03 15:47:45 Re: Misleading error message in logical decoding for binary plugins