Re: Switch pg_basebackup to use -X stream instead of -X fetch by default?

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Switch pg_basebackup to use -X stream instead of -X fetch by default?
Date: 2014-08-26 20:46:31
Message-ID: 20140826204631.GU21544@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-08-26 16:41:44 -0400, Peter Eisentraut wrote:
> On 8/26/14 12:40 PM, Magnus Hagander wrote:
> > I think the first reason is gone now, and the risk/damage of the two
> > connections is probably smaller than running out of WAL. -x is a good
> > default for smaller systems, but -X is a safer one for bigger ones. So
> > I agree that changing the default mode would make sense.
>
> I would seriously consider just removing one of the modes. Having two
> modes is complex enough, and then having different defaults in different
> versions, and fuzzy recommendations like, it's better for "smaller
> systems", it's quite confusing.

Happy with removing the option and just accepting -X for backward
compat.

> I don't think it's a fundamental problem to say, you need 2 connections
> to use this feature. (For example, you need a second connection to
> issue a cancel request. Nobody has ever complained about that.)

Well, replication connections are more limited in number than normal
connections... And cancel requests are very short lived.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2014-08-26 20:56:05 Re: proposal: rounding up time value less than its unit.
Previous Message Peter Eisentraut 2014-08-26 20:41:44 Re: Switch pg_basebackup to use -X stream instead of -X fetch by default?