Re: wrapping in extended mode doesn't work well with default pager

From: Noah Misch <noah(at)leadboat(dot)com>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Emre Hasegeli <emre(at)hasegeli(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: wrapping in extended mode doesn't work well with default pager
Date: 2014-08-20 03:34:12
Message-ID: 20140820033412.GA499755@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 18, 2014 at 12:30:40PM +0100, Greg Stark wrote:
> On Tue, Aug 5, 2014 at 3:41 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> > This remains open for 9.4. Your proposal to revert the feature in 9.4 and fix
> > it in 9.5 sounds reasonable.
>
> Ok, I've gone ahead and done this. I'm sorry for the delays and confusion.

Thanks.

> > I did try psql-wrapped-expanded-fix-v5.patch with the tests Peter and I posted
> > upthread, and those tests now behave as they do in released versions. What
> > cases did you find that still change vs. 9.3?
>
> I was trying to build a spreadsheet of every combination of these
> options. It turns out that 4-dimensional spreadsheets are kind of
> awkward.

What's one query that still behaves differently in 9.5 vs. 9.3 (under
formatting options that exist in both versions)?

> I think the fundamental dilemma was the same that was discussed
> upthread. If wrapped expanded mode should have an extra space padding
> column for the wrap indicators then all expanded modes should have
> that column to be consistent since wrapping shouldn't change the
> amount of padding.

I might agree for a greenfield design, but -1 for changing expanded mode now
to improve consistency in this way. I predict the complaints from users of
expanded mode in automation would overpower any applause for the consistency.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-08-20 04:14:32 Re: replication commands and log_statements
Previous Message Josh Berkus 2014-08-20 01:25:39 Re: jsonb format is pessimal for toast compression