Re: pgsql: Fix bug in checking of IDENTIFY_SYSTEM result.

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Fujii Masao <fujii(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix bug in checking of IDENTIFY_SYSTEM result.
Date: 2014-08-19 08:48:24
Message-ID: 20140819084824.GA11993@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2014-08-19 08:44:41 +0000, Fujii Masao wrote:
> Fix bug in checking of IDENTIFY_SYSTEM result.
>
> 5a991ef8692ed0d170b44958a81a6bd70e90585 added new column into
> the result of IDENTIFY_SYSTEM command. But it was not reflected into
> several codes checking that result. Specifically though the number of
> columns in the result was increased to 4, it was still compared with 3
> in some replication codes.
>
> Back-patch to 9.4 where the number of columns in IDENTIFY_SYSTEM
> result was increased.
>
> Report from Michael Paquier

Uh. This is wrong. Those code locations where adjusted, but we chose not
to require 4 columns because that prohibits using the utilities against
< 9.4.

Where was this "bug" reported?

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2014-08-19 09:51:31 pgsql: Revert "Fix bug in checking of IDENTIFY_SYSTEM result."
Previous Message Fujii Masao 2014-08-19 08:44:41 pgsql: Fix bug in checking of IDENTIFY_SYSTEM result.