| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Emre Hasegeli <emre(at)hasegeli(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: wrapping in extended mode doesn't work well with default pager |
| Date: | 2014-08-05 02:41:02 |
| Message-ID: | 20140805024102.GC62571@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This remains open for 9.4. Your proposal to revert the feature in 9.4 and fix
it in 9.5 sounds reasonable.
On Thu, Jul 10, 2014 at 04:15:35PM +0100, Greg Stark wrote:
> On Mon, Jul 7, 2014 at 8:35 AM, Sergey Muraviov
> <sergey(dot)k(dot)muraviov(at)gmail(dot)com> wrote:
> > So what's wrong with the patch?
> > And what should I change in it for 9.5?
>
> Possibly nothing. The concern was tha it's modifying the output in
> cases where the output is not \expanded and/or not wrapped. Now I've
> mostly convinced myself that those cases should change to be
> consistent with the wrapped output but there was at least one tool
> depending on that format (check_postgres) so perhaps it's not
> worthwhile and having it be inconsistent would be safer.
I did try psql-wrapped-expanded-fix-v5.patch with the tests Peter and I posted
upthread, and those tests now behave as they do in released versions. What
cases did you find that still change vs. 9.3?
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2014-08-05 03:09:10 | Re: 9.5: Better memory accounting, towards memory-bounded HashAgg |
| Previous Message | Josh Berkus | 2014-08-05 00:15:31 | Re: Proposal to add a QNX 6.5 port to PostgreSQL |