Re: Is analyze_new_cluster.sh still useful?

From: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Is analyze_new_cluster.sh still useful?
Date: 2014-08-04 08:17:40
Message-ID: 20140804081740.GA25484@msg.credativ.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Re: Bruce Momjian 2014-07-29 <20140729094234(dot)GC13958(at)momjian(dot)us>
> On Fri, Jun 20, 2014 at 05:15:05PM +0200, Christoph Berg wrote:
> > Another nitpick here: What pg_upgrade outputs doesn't even work on
> > most systems, you need to ./analyze_new_cluster.sh or "sh
> > analyze_new_cluster.sh".
>
> Well, the output is:
>
> Optimizer statistics are not transferred by pg_upgrade so,
> once you start the new server, consider running:
> analyze_new_cluster.sh
>
> Running this script will delete the old cluster's data files:
> delete_old_cluster.sh
>
> It is not really telling you _how_ to run them. Would adding a ./
> prefix help?

I think it would help in hinting the user that these are not
system-wide commands in $PATH but rather scripts in the current
directory.

There's also a case for prefixing them with the full path, Debian's
pg_upgradecluster wrapper drops these scripts in a new subdirectory in
/var/log/postgresql/ along with the log files. Possibly other
automation frameworks do likewise. (Though the frameworks will likely
make delete_old_cluster.sh redundant.)

Christoph
--
Senior Berater, Tel.: +49 (0)21 61 / 46 43-187
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Hohenzollernstr. 133, 41061 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
pgp fingerprint: 5C48 FE61 57F4 9179 5970 87C6 4C5A 6BAB 12D2 A7AE

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-08-04 08:48:38 Re: Looked at TODO:Considering improving performance of computing CHAR() value lengths
Previous Message Gabriele Bartolini 2014-08-04 08:15:29 Re: Proposal: Incremental Backup