Re: BUG #10794: psql sometimes ignores .psqlrc

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marko Tiikkaja <marko(at)joh(dot)to>, pgsql-bugs(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: BUG #10794: psql sometimes ignores .psqlrc
Date: 2014-07-16 02:36:56
Message-ID: 20140716023656.GV16422@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

(adding Peter to the CC, as the author of 9099e4afe)

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> >> In any case, I'm disinclined to mess with this in the back branches ...
>
> > If we have a simple/clean patch to fix the "Ctrl-C ignored at password
> > prompt", such that, instead, psql exits more-or-less immediately then
> > I'd be for back-patching just that as it certainly has always felt like
> > a wart or even a bug to me, but I agree that we don't want to introduce
> > other behavior changes beyond that in back-branches.
>
> That would be commit 9099e4afe. I won't vote against back-patching if
> people think it's unlikely that anyone is expecting the old behavior.

I'm having a hard time seeing how someone would be depending on the old
behavior. I'm for back-patching that change but given that it's in the
client, I won't press the issue if someone actually feels like there's a
chance it'd break some existing usage.

Peter- any particular reason you didn't backpatch 9099e4afe? Were you
concerned that it would break something for people, or just didn't as it
wasn't asked for? (If so- please consider it now asked for.. :)

> > While we're at it, we should fix the complaint about .psql_history being
> > missing.. This isn't an error, imv:
> > could not save history to file "/home/sfrost/.psql_history": No such file or directory
>
> Eh? I've not seen anything like that personally. I seem to recall having
> heard of it happening with broken readline or libedit versions, but we
> don't have very much ability to work around bugs in those.

Oh? I get it every time I run psql w/o a .psql_history file on a stock
Ubuntu system which certainly has a current libreadline installed..
Will have to investigate a bit more.

Thanks,

Stephen

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2014-07-16 03:36:33 Re: BUG #10794: psql sometimes ignores .psqlrc
Previous Message Tom Lane 2014-07-16 02:29:04 Re: BUG #10794: psql sometimes ignores .psqlrc