From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgindent weirdness |
Date: | 2014-07-10 18:03:25 |
Message-ID: | 20140710180325.GA7366@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jul 10, 2014 at 12:02:50PM -0400, Robert Haas wrote:
> In contrib/test_shm_mq/test.c, the 9.4 pgindent run
> (0a7832005792fa6dad171f9cadb8d587fe0dd800) did this:
>
> -PG_MODULE_MAGIC;
> -PG_FUNCTION_INFO_V1(test_shm_mq);
> +PG_MODULE_MAGIC; PG_FUNCTION_INFO_V1(test_shm_mq);
> PG_FUNCTION_INFO_V1(test_shm_mq_pipelined);
>
> This is obviously not an improvement. Is there some formatting rule
> that I violated in the original code that lead to this, or what?
Uh, ever other case of PG_MODULE_MAGIC had blank lines before/after this
define. I went and added that to test_shm_mq/test.c, and adjusted other
blank lines to be consistent. I did not modify 9.4 as this cosmetic.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-07-10 19:06:02 | Re: IMPORT FOREIGN SCHEMA statement |
Previous Message | Claudio Freire | 2014-07-10 17:40:12 | Re: Minmax indexes |