Re: replicating DROP commands across servers

From: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: replicating DROP commands across servers
Date: 2014-06-30 08:56:23
Message-ID: 20140630085623.GA29978@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi.

I thought I'd review this patch, since pgaudit uses the
pg_event_trigger_dropped_objects function.

I went through the patch line by line, and I don't really have anything
to say about it. I notice that there are some XXX/FIXME comments in the
code, but it's not clear if those need to (or can be) fixed before the
code is committed.

Everything else looks good. I think this is ready for committer.

-- Abhijit

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ronan Dunklau 2014-06-30 09:01:48 Re: IMPORT FOREIGN SCHEMA statement
Previous Message Ashutosh Bapat 2014-06-30 08:47:29 Re: inherit support for foreign tables