Re: Cluster name in ps output

From: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
To: Thomas Munro <munro(at)ip9(dot)org>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Cluster name in ps output
Date: 2014-06-25 04:29:30
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


I reviewed the version of this patch without log_line_prefix support,
since that seemed to be generally acceptable in followup discussion.

The patch didn't apply any more because of some changes to guc.c, but it
was trivial to regenerate (fixed patch attached).

> diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
> index 70e5a51..84ae5f3 100644
> --- a/src/backend/utils/misc/postgresql.conf.sample
> +++ b/src/backend/utils/misc/postgresql.conf.sample
> @@ -74,6 +74,8 @@
> # (change requires restart)
> #bonjour_name = '' # defaults to the computer name
> # (change requires restart)
> +#cluster_name = '' # defaults to the computer name
> + # (change requires restart)

Cut-and-paste error (there's no default). Also fixed in the attached

The patch looks OK, and works as advertised (I tested on Linux). If we
want the feature (I like it), this patch is a good enough way to get it.

I'm marking it ready for committer.

-- Abhijit

Attachment Content-Type Size
cluster-name.diff text/x-diff 4.0 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2014-06-25 05:01:54 Re: idle_in_transaction_timeout
Previous Message Tom Lane 2014-06-25 04:27:57 Re: makeAndExpr(), etc. confined to gram.y?