| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Rahila Syed <rahilasyed90(at)gmail(dot)com> |
| Cc: | Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Rahila Syed <rahilasyed(dot)90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
| Date: | 2014-06-18 12:43:02 |
| Message-ID: | 20140618124302.GL3115@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-06-18 18:10:34 +0530, Rahila Syed wrote:
> Hello ,
>
> >I have a few preliminary comments about your patch
> Thank you for review comments.
>
> >the patch creates src/common/lz4/.travis.yml, which it shouldn't.
> Agree. I will remove it.
>
> >Shouldn't this use palloc?
> palloc() is disallowed in critical sections and we are already in CS while
> executing this code. So we use malloc(). It's OK since the memory is
> allocated just once per session and it stays till the end.
malloc() isn't allowed either. You'll need to make sure all memory is
allocated beforehand
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abhijit Menon-Sen | 2014-06-18 12:55:34 | Re: [REVIEW] Re: Compression of full-page-writes |
| Previous Message | Rahila Syed | 2014-06-18 12:40:34 | Re: [REVIEW] Re: Compression of full-page-writes |