| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_control is missing a field for LOBLKSIZE |
| Date: | 2014-06-17 19:55:02 |
| Message-ID: | 20140617195502.GJ18688@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian wrote:
> On Tue, Jun 17, 2014 at 12:28:46PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > > Uh, I think pg_upgrade needs to check that they match too.
> >
> > Possibly. What do you think it should do when examining a pg_control
> > version that lacks the field?
>
> Good question. I have existing cases where fields were removed, but not
> ones that were added. As we have no way to query the old cluster's
> value for LOBLKSIZE, I think I will just add code to compare them if
> they _both_ exist.
Can't you compare it to the historic default value? I mean, add an
assumption that people thus far has never tweaked it.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-06-17 20:07:55 | Re: delta relations in AFTER triggers |
| Previous Message | Robert Haas | 2014-06-17 19:41:04 | Re: API change advice: Passing plan invalidation info from the rewriter into the planner? |