Re: Shared memory changes in 9.4?

From: Christoph Berg <cb(at)df7cb(dot)de>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Shared memory changes in 9.4?
Date: 2014-06-12 13:39:14
Message-ID: 20140612133913.GE6907@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Re: Andres Freund 2014-06-12 <20140612094112(dot)GZ8406(at)alap3(dot)anarazel(dot)de>
> > * Make initdb determine the best shm type for this platform and write
> > it into postgresql.conf as it does now.
> > * If no dynamic_shared_memory_type is found in the config, default to
> > "none".
> > * Modify the three identical error messages concerned about shm
> > segments to include the shm type instead of always just saying
> > "FATAL: could not open shared memory segment"
> > * Add a HINT to the POSIX error message:
> > "HINT: This might indicate that /dev/shm is not mounted, or its
> > permissions do not allow the database user to create files there"
>
> Sounds like a sane plan to me.

Here are two patches, one that implements the annotated error
messages, and one that selects none as default.

It might also make sense to add a Note that POSIX depends on /dev/shm,
and also a Note that dynamic_shared_memory_type is not related to
the shared_buffers shm segments, which I didn't include here.

Christoph
--
cb(at)df7cb(dot)de | http://www.df7cb.de/

Attachment Content-Type Size
dsm_errormessages.patch text/x-diff 11.5 KB
dsm-default-none.patch text/x-diff 3.2 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message boca2608 2014-06-12 13:51:03 Re: Cannot start Postgresql 9.3 as a service in Windows 2012 Server with a domain account
Previous Message Igor Neyman 2014-06-12 13:35:36 Re: what does pg_activity mean when the database is stuck?

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-06-12 13:55:30 Re: replication commands and log_statements
Previous Message Kevin Grittner 2014-06-12 13:13:24 Re: API change advice: Passing plan invalidation info from the rewriter into the planner?