From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, bastian(dot)blank(at)credativ(dot)de |
Subject: | Re: 9.4 beta1 crash on Debian sid/i386 |
Date: | 2014-05-19 14:12:21 |
Message-ID: | 20140519141221.GC5098@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2014-05-19 09:53:11 -0400, Tom Lane wrote:
> I think throwing an error out of a SIGBUS handler is right out. There
> would be no way to know exactly what code we were interrupting. It's
> the same reason we don't let, eg, the SIGALRM handler throw a timeout
> error directly (in most places anyway).
Agreed. I think if we really, really feel the need to do something about
this - which I don't - we could allocate a separate stack very early on
and use that.
> >> * PostgreSQL allocates lots of heap using brk() instead of mmap()
>
> > It doesn't really do that, btw. It's the libc's mmap that makes those
> > decisions, not postgres.
>
> It occurs to me that maybe this is a glibc bug, not a kernel bug?
You think malloc() should try to be careful when calling brk() and check
beforehand wether it'll conflict with stack_base + RLIMIT_STACK? That's
not a bad argument, but it still seems a really bad choice to leave that
little space for the heap. Especially when it's dependant on -pie being
used.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-05-19 14:23:43 | Re: 9.4 release notes |
Previous Message | Tom Lane | 2014-05-19 13:53:11 | Re: 9.4 beta1 crash on Debian sid/i386 |