From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | folder:lk/lk date:yesterday.. |
Date: | 2014-04-30 15:39:27 |
Message-ID: | 20140430153927.GC30324@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Coverity flagged a couple of issues that seem to worth addressing by
changing the code instead of ignoring them:
01) heap_xlog_update() looks to coverity as if it could trigger a NULL
pointer dereference. That's because it thinks that oldtup.t_data is
NULL if XLR_BKP_BLOCK(0) while reconstructing incremental
tuples. That fortunately can't happen as incremental updates are
only performed if the tuples are on the same page.
Add an Assert().
02) Be a bit more consistent in what type to use for a size
variable. Inconsequential, but more consistent.
03) Don't leak memory after connection aborts in pg_recvlogical.
04) Use a sensible parameter for memset() when randomizing memory in
reorderbuffer. Inconsequential.
Could somebody please pick these up?
I have to say, I am not particularly happy with the complexity of the
control flow in heap_xlog_update() :(.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-04-30 15:41:30 | Re: folder:lk/lk date:yesterday.. |
Previous Message | Rajmohan C | 2014-04-30 15:33:32 | hooks not working in postgresql 9.3 (building from source) |