Re: [patch] Adding EXTRA_REGRESS_OPTS to all pg_regress invocations

On Thu, Mar 27, 2014 at 06:03:24PM +0100, Christoph Berg wrote:
> Re: Bruce Momjian 2013-12-04 <20131204151533(dot)GB17114(at)momjian(dot)us>
> > On Mon, May 6, 2013 at 11:51:47PM -0700, Christoph Berg wrote:
> > > "make check" supports EXTRA_REGRESS_OPTS to pass extra options to
> > > pg_regress, but all the other places where pg_regress is used do not
> > > allow this. The attached patch adds EXTRA_REGRESS_OPTS to
> > > Makefile.global.in (for contrib modules) and two more special
> > > Makefiles (isolation and pg_upgrade).
> > >
> > > The use case here is that Debian needs to be able to redirect the unix
> > > socket directory used to /tmp, because /var/run/postgresql isn't
> > > writable for the buildd user. The matching part for this inside
> > > pg_regress is still in discussion here, but the addition of
> > > EXTRA_REGRESS_OPTS is an independent step that is also useful for
> > > others, so I'd like to propose it for inclusion.
> >
> > Thanks, patch applied. This will appear in PG 9.4. I suppose we could
> > backpatch this but I would need community feedback on that.
>
> Thanks for pushing this. In the meantime, a new bit has appeared:
> The new contrib/test_decoding checks make use of the
> pg_isolation_regress_check macros (which the isolation test itself
> doesn't). These macros also need EXTRA_REGRESS_OPTS, on top of
> 86ef4796f5120c55d1a48cfab52e51df8ed271b5:

Applied.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +