| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: trailing comment ghost-timing |
| Date: | 2014-04-10 21:17:11 |
| Message-ID: | 20140410211711.GH6917@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 31, 2014 at 02:06:28PM -0400, Bruce Momjian wrote:
> Where are we on this? It seem odd that psql sends /* */ comments to the
> server, but not "--" comments. Should this be documented or changed?
>
> I am confused why changing the behavior would affect the regression test
> output as -- and /* */ comments already appear, and it was stated that
> "--" comments are already not sent to the server.
>
> Everyone agreed that suppressing \timing output for a PGRES_EMPTY_QUERY
> return result was not a good idea.
I have applied the attached document patch to document that '--'
comments are not passed to the server, while C-style block comments are.
We can call this a feature. ;-)
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| Attachment | Content-Type | Size |
|---|---|---|
| psql.diff | text/x-diff | 606 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Florian Pflug | 2014-04-10 21:33:58 | Re: [PATCH] Negative Transition Aggregate Functions (WIP) |
| Previous Message | Heikki Linnakangas | 2014-04-10 20:43:20 | Re: Partial match fix for fast scan |