Re: pgsql: Several fixes to array handling in ecpg.

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Several fixes to array handling in ecpg.
Date: 2014-04-10 18:44:27
Message-ID: 20140410184427.GA10589@feivel.credativ.lan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Apr 10, 2014 at 09:44:39AM -0400, Tom Lane wrote:
> This patch is causing almost all of the Windows buildfarm members to
> fail with compilation errors, along the lines of

Argh, I stopped monitoring the buildfarm for this patch when the first 5 to 10
members came up green. Windows being so special, I shouild have waited.

Anyway, I just committed a fix that, hopefully, fixes the problem. I do not
have any Windows system to test with myself.

> No idea why. It's also interesting that only HEAD seems to be affected.

That's easy to explain. There were a couple small changes on the test suite
that made adding another test to older version more hassle than anything else.
Or in other words, the new test simply wasnt backported.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-04-10 20:42:13 pgsql: Fix bugs in GIN "fast scan" with partial match.
Previous Message Michael Meskes 2014-04-10 18:40:32 pgsql: The new pointer_to_struct test needs a special command line para