Re: pgsql: Several fixes to array handling in ecpg.

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Several fixes to array handling in ecpg.
Date: 2014-04-09 10:46:35
Message-ID: 20140409104635.GA18710@feivel.credativ.lan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> > Several fixes to array handling in ecpg.
>
> What's actually fixed by this?

There were a couple of reports that data got filled into array incorrectly and at least some of those were fixed by the patches.

> The patch, or at least the comments, don't look entirely finished:
> + /*
> + * If siz i.e. the size of structure of which this variable is part of,
> + * that gives the offset to the next element, if required
> + */

Not sure what you're trying to tell me here, other than that the wording is unclear.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2014-04-09 10:50:18 Re: pgsql: Several fixes to array handling in ecpg.
Previous Message Andres Freund 2014-04-09 10:33:35 Re: pgsql: Several fixes to array handling in ecpg.