Re: FastPathStrongRelationLocks still has an issue in HEAD

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FastPathStrongRelationLocks still has an issue in HEAD
Date: 2014-04-07 14:48:55
Message-ID: 20140407144855.GD4161@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-04-07 10:45:51 -0400, Robert Haas wrote:
> On Mon, Apr 7, 2014 at 10:20 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> > Hm. It generally might be interesting to get a few !X86 buildfarms
> > running builds with LTO enabled. That might expose some dangerous
> > assumptions more easily.
>
> I strongly suspect that will break stuff all over the place. We can
> either get compiler barriers working for real, or we can start
> volatile-izing every reference in an LWLock-protected critical
> section. Hint: the second one is insane.

You don't have to convince me. The way there is where I am not sure
we're agreeing.

I didn't break a few months back for x86 on light loads btw. Not that
that's saying much.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-04-07 14:50:32 Re: gsoc knn spgist
Previous Message Robert Haas 2014-04-07 14:48:39 Re: [bug fix] pg_ctl always uses the same event source