|From:||Andres Freund <andres(at)anarazel(dot)de>|
|To:||David Fetter <david(at)fetter(dot)org>|
|Cc:||Karol Trzcionka <karlikt(at)gmail(dot)com>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Marko Tiikkaja <marko(at)joh(dot)to>, pgsql-hackers(at)postgresql(dot)org|
|Subject:||Re: GSOC13 proposal - extend RETURNING syntax|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Some comments about the patch:
* Coding Style:
* multiline comments have both /* and */ on their own lines.
* I think several places indent by two tabs.
* Spaces around operators
* Many of the new comments would enjoy a bit TLC by a native speaker.
* The way RTE_ALIAS creeps in many place where it doesn't seem to belong
seems to indicate that the design isn't yet ready. I share Robert's
suspicion that this would be better solved by referring to a special
range table entry.
Based on the lack of activity around this and the fact that this needs a
*significant* chunk of work before being committable, I am going to mark
this as returned with feedback.
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
|Next Message||Robert Haas||2014-04-04 16:15:14||Re: B-Tree support function number 3 (strxfrm() optimization)|
|Previous Message||Noah Misch||2014-04-04 16:13:34||Re: B-Tree support function number 3 (strxfrm() optimization)|