Re: get_fn_expr_variadic considered harmful

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: get_fn_expr_variadic considered harmful
Date: 2014-04-01 18:26:57
Message-ID: 20140401182657.GG3750@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-04-01 12:52:54 -0400, Tom Lane wrote:
> We could possibly salvage something by redefining funcvariadic as only
> being true if VARIADIC was used *and* the function is VARIADIC ANY,
> so that it returns to not being different for semantically-equivalent
> cases. This would be a bit messy, since it would not un-break the
> behavior for any already stored rules or indexes in 9.3 databases.
> But I'm not sure there is any good way to make the problem magically
> go away in 9.3 databases.

It's pretty damn ugly, but if we're going for magic in around those
edges, we could just force the new behaviour in readfuncs.c. IIUC all
the neccessary data for it is there.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-04-01 18:33:37 Re: get_fn_expr_variadic considered harmful
Previous Message Tom Lane 2014-04-01 18:23:33 Re: get_fn_expr_variadic considered harmful