Re: psql \d+ and oid display

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, David Johnston <polobo(at)yahoo(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: psql \d+ and oid display
Date: 2014-03-29 22:33:39
Message-ID: 20140329223339.GD30470@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 29, 2014 at 06:16:19PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Are you saying most people like "Has OIDs: yes", or the idea of just
> > displaying _a_ line if there are OIDs? Based on default_with_oids,
> > perhaps we should display "With OIDs".
>
> > I agree it is no unanimous. I am curious how large the majority has to
> > be to change a psql display value.
>
> What I actually suggested was not *changing* the line when it's to be
> displayed, but suppressing it in the now-standard case where there's no
> OIDs.
>
> Personally I find the argument that backwards compatibility must be
> preserved to be pretty bogus; we have no hesitation in changing the
> output of \d anytime we add a new feature. So I don't think there's
> a good compatibility reason why the line has to be spelled exactly
> "Has OIDs: yes" --- but there is a consistency reason, which is that
> everything else we print in this part of the \d output is of the form
> "label: info".

Ah, now I understand it --- you can argue that the new "Replica
Identity" follows the same pattern, showing only for non-defaults (or at
least it will once I commit the pending patch to do that).

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2014-03-29 23:00:51 Re: Useless "Replica Identity: NOTHING" noise from psql \d
Previous Message David Johnston 2014-03-29 22:32:48 Re: PQputCopyData dont signal error