Re: Useless "Replica Identity: NOTHING" noise from psql \d

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Useless "Replica Identity: NOTHING" noise from psql \d
Date: 2014-03-27 14:05:10
Message-ID: 20140327140510.GC11694@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 27, 2014 at 02:41:40PM +0100, Christoph Berg wrote:
> Re: Bruce Momjian 2014-03-27 <20140327131048(dot)GA11694(at)momjian(dot)us>
> > On Thu, Mar 27, 2014 at 10:02:20AM +0100, Christoph Berg wrote:
> > > Re: Bruce Momjian 2014-03-26 <20140326161056(dot)GA468(at)momjian(dot)us>
> > > > The attached patch matches your suggestion. It is basically back to
> > > > what the code originally had, except it skips system tables, and shows
> > > > "???" for invalid values.
> > >
> > > Fwiw, "make check-world" is currently broken:
> >
> > Yes, the patch was partial to just show the code changes, to get
> > approval. Attached is the full patch.
>
> I meant to say what's actually in git HEAD at the moment is broken.
> The regression.diffs are without an extra patch. This prevents
> building 9.4devel packages for apt.postgresql.org now.

Uh, I thought that might be what you were saying, but I am not seeing
any failures here. I don't see any platform-specific regression files
in the files I modified. Can you show me the failures?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-03-27 14:13:36 Re: Useless "Replica Identity: NOTHING" noise from psql \d
Previous Message Christoph Berg 2014-03-27 13:41:40 Re: Useless "Replica Identity: NOTHING" noise from psql \d