| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Pavel Golub <pavel(at)gf(dot)microolap(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: exit_horribly vs exit_nicely in pg_dump |
| Date: | 2014-03-05 23:15:49 |
| Message-ID: | 20140305231549.GC20275@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 6, 2013 at 08:47:43AM -0500, Peter Eisentraut wrote:
> On 11/5/13, 8:46 AM, Pavel Golub wrote:
> > I suppose this should be call to exit_nicely() for all possible cases.
> >
> > The only need for calling exit_horribly() is when we are deep down in
> > the multithreaded code, AFAIK.
>
> Doesn't hurt either, though. But it would be OK to make this more
> consistent.
Fixed in attached applied patch.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| Attachment | Content-Type | Size |
|---|---|---|
| pg_dump.diff | text/x-diff | 941 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-03-05 23:50:15 | Re: Unportable coding in reorderbuffer.h |
| Previous Message | Bruce Momjian | 2014-03-05 23:08:38 | Re: pg_ctl status with nonexistent data directory |