Re: Minor comment improvements in tablecmds.c

Etsuro Fujita wrote:
> This is a small patch to improve comments in tablecmds.c. Please find
> attached a patch.

I find both patched and unpatched to be pretty illegible. How about
something like

> /*
> - * Execute ALTER TABLE/INDEX/SEQUENCE/VIEW/FOREIGN TABLE RENAME
> + * Execute ALTER <relation type> RENAME
> + * This routine supports tables, indexes, sequences, views,
> + * and foreign tables
> */

and the two other ones with something like this:

> /*
> - * Grab an exclusive lock on the target table, index, sequence or view,
> - * which we will NOT release until end of transaction.
> + * Grab an exclusive lock on the target relation,
> + * which we will NOT release until
> + * end of transaction.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services