From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomáš Vondra <tv(at)fuzzy(dot)cz> |
Subject: | Re: Fwd: patch: make_timestamp function |
Date: | 2014-02-19 18:01:04 |
Message-ID: | 20140219180103.GB4759@eldon.alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Pavel Stehule escribió:
> > 7) Why do the functions accept only the timezone abbreviation, not the
> > full name? I find it rather confusing, because the 'timezone' option
> > uses the full name, and we're using this as the default. But doing
> > 'show timestamp' and using the returned value fails. Is it possible
> > to fix this somehow?
>
> A only abbreviation is allowed for timetz type. Timestamp can work with
> full time zone names. A rules (behave) should be same as input functions
> for types: timestamptz and timetz.
>
> postgres=# select '10:10:10 CET'::timetz;
> timetz
> ─────────────
> 10:10:10+01
> (1 row)
>
> postgres=# select '10:10:10 Europe/Prague'::timetz;
> ERROR: invalid input syntax for type time with time zone: "10:10:10
> Europe/Prague"
> LINE 1: select '10:10:10 Europe/Prague'::timetz;
> ^
>
> This limit is due used routines limits.
I think this is a strange limitation, and perhaps it should be fixed
rather than inflicting the limitation on the new function.
I tweaked your patch a bit, attached; other than defining what to do
about full TZ names in timetz, this seems ready to commit.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
make_timestamp-2014-02-19-01.patch | text/x-diff | 29.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2014-02-19 18:01:56 | Re: Changeset Extraction v7.6.1 |
Previous Message | Robert Haas | 2014-02-19 18:01:02 | Re: Changeset Extraction v7.6.1 |