| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A minor correction in comment in heaptuple.c |
| Date: | 2014-01-28 17:25:51 |
| Message-ID: | 20140128172551.GQ10723@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian escribió:
> On Tue, Jan 28, 2014 at 11:20:39AM -0500, Tom Lane wrote:
> > Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > > On 2014-01-28 11:14:49 -0500, Bruce Momjian wrote:
> > >> OK, so does anyone object to removing this comment line?
> >
> > > Let's just not do anything. This is change for changes sake. Not
> > > improving anything the slightest.
> >
> > Indeed. I'd actually request that you revert your previous change to the
> > comment, as it didn't improve matters and is only likely to cause pain for
> > future back-patching.
>
> OK, so we have a don't change anything and a revert. I am thinking the
> new wording as a super-minor improvement. Anyone else want to vote?
I vote to revert to the original and can we please wait for longer than
a few hours on a weekend before applying this kind of change that is
obviously not without controversy.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-01-28 17:26:56 | Re: ALTER TABLE lock strength reduction patch is unsafe |
| Previous Message | Heikki Linnakangas | 2014-01-28 17:21:50 | Re: ALTER TABLE lock strength reduction patch is unsafe |