| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
| Cc: | "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>, Andres Freund <andres(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A minor correction in comment in heaptuple.c |
| Date: | 2014-01-28 16:14:49 |
| Message-ID: | 20140128161449.GD20898@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 27, 2014 at 02:51:59PM -0800, Kevin Grittner wrote:
> So anyway, *I* would object to applying that; it was meant to
> illustrate what the comment, if any, should cover; not to be an
> actual code change. I don't think the change that was pushed helps
> that comment carry its own weight, either. If we can't do better
> than that, we should just drop it.
>
> I guess I won't try to illustrate a point *that* particular way
> again....
OK, so does anyone object to removing this comment line?
slot_attisnull()
...
/*
--> * assume NULL if attnum is out of range according to the tupdesc
*/
if (attnum > tupleDesc->natts)
return true;
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 1008 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-01-28 16:16:16 | Re: A minor correction in comment in heaptuple.c |
| Previous Message | Christian Kruse | 2014-01-28 16:11:11 | Re: [PATCH] Use MAP_HUGETLB where supported (v3) |