Re: INTERVAL overflow detection is terribly broken

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Florian Pflug <fgp(at)phlo(dot)org>
Cc: Rok Kralj <rok(dot)kralj(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: INTERVAL overflow detection is terribly broken
Date: 2014-01-27 22:26:35
Message-ID: 20140127222635.GD8691@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 27, 2014 at 04:47:22PM -0500, Bruce Momjian wrote:
> The updated attached patch has overflow detection for interval
> subtraction, multiply, and negate. There are also some comparison
> cleanups.

Oh, one odd thing about this patch. I found I needed to use INT64_MAX,
but I don't see it used anywhere else in our codebase. Is this OK? Is
there a better way?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2014-01-27 22:28:27 Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Previous Message Andrew Dunstan 2014-01-27 22:01:36 Re: Add min and max execute statement time in pg_stat_statement