From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: ERROR during end-of-xact/FATAL |
Date: | 2013-12-20 15:44:06 |
Message-ID: | 20131220154406.GA22570@eldon.alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas escribió:
> On Thu, Nov 28, 2013 at 10:10 AM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
> > Robert Haas escribió:
> >> On Wed, Nov 6, 2013 at 9:40 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> >> > Noah Misch wrote:
> >> >> Incomplete list:
> >> >>
> >> >> - If smgrDoPendingDeletes() finds files to delete, mdunlink() and its callee
> >> >> relpathbackend() call palloc(); this is true in all supported branches. In
> >> >> 9.3, due to commit 279628a0, smgrDoPendingDeletes() itself calls palloc().
> >> >> (In fact, it does so even when the pending list is empty -- this is the only
> >> >> palloc() during a trivial transaction commit.) palloc() failure there
> >> >> yields a PANIC during commit.
> >> >
> >> > I think we should fix this routine to avoid the palloc when not necessary.
> >> > That initial palloc is pointless.
> >
> > Here's a trivial patch we could apply to 9.3 immediately. Anything else
> > such as the ideas proposed below would require more effort than anyone
> > can probably spend here soon.
>
> Yeah, this seems like a good thing to do for now.
Pushed, thanks.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Adrian Klaver | 2013-12-20 15:54:25 | Re: pg_upgrade & tablespaces |
Previous Message | Joseph Kregloh | 2013-12-20 15:32:53 | Re: pg_upgrade & tablespaces |